Re: [PATCH v2 2/3] net_sched: Add accessor function for packet length for qdiscs
From: Jarek Poplawski <hidden>
Date: 2008-07-25 12:49:07
From: Jarek Poplawski <hidden>
Date: 2008-07-25 12:49:07
On Fri, Jul 25, 2008 at 03:29:32PM +0300, Jussi Kivilinna wrote:
Quoting "Jarek Poplawski" [off-list ref]:quoted
OK, I see htb did this earlier with ".packets", so it looks like I'm wrong with this - sorry! (Anyway, it seems to unnecessarily restrict the way qdisc are working.)Would it be better for qdisc_enqueue() to pass packet length to caller?
Is it's really needed? Actually, if it's only for stats, I really can't see the reason why not to get this info old way - before enqueing? (And this could be not enough if we want packets count like in htb.) Jarek P.