Re: [PATCH v2 2/3] net_sched: Add accessor function for packet length for qdiscs
From: David Miller <davem@davemloft.net>
Date: 2008-07-25 12:16:06
From: David Miller <davem@davemloft.net>
Date: 2008-07-25 12:16:06
From: Jarek Poplawski <redacted> Date: Fri, 25 Jul 2008 12:08:49 +0000
On Fri, Jul 25, 2008 at 04:52:15AM -0700, David Miller wrote:quoted
What TCP depends upon is that DROP means DROP, and that the packet never reached the device and has been freed.IMHO, TCP should depend on it's skb "refcount". A qdisc, after passing skb to other qdisc shouldn't depend on TCP's "refcount" because not everything has to work like TCP.
I think it is reasonable for TCP to expect lower layers to not return garbage. We have cases like this all over the stack, where some code gives some specific return value, which means "the packet was freed and not further processed." There is no difference for this case.