Re: [PATCH 2/4] qla3xxx: Hold RTNL while calling dev_close()
From: Jeff Garzik <hidden>
Date: 2008-06-27 05:32:28
From: Jeff Garzik <hidden>
Date: 2008-06-27 05:32:28
Ben Hutchings wrote:
dev_close() must be called holding the RTNL. Compile-tested only. Signed-off-by: Ben Hutchings <redacted> --- drivers/net/qla3xxx.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)diff --git a/drivers/net/qla3xxx.c b/drivers/net/qla3xxx.c index b7f7b22..bccee68 100644 --- a/drivers/net/qla3xxx.c +++ b/drivers/net/qla3xxx.c@@ -3701,7 +3701,9 @@ static int ql_cycle_adapter(struct ql3_adapter *qdev, int reset) printk(KERN_ERR PFX "%s: Driver up/down cycle failed, " "closing device\n",qdev->ndev->name); + rtnl_lock(); dev_close(qdev->ndev); + rtnl_unlock(); return -1;
applied