Re: [PATCH] sky2: Hold RTNL while calling dev_close() [2nd try]
From: Jeff Garzik <hidden>
Date: 2008-06-10 22:41:06
From: Jeff Garzik <hidden>
Date: 2008-06-10 22:41:06
Ben Hutchings wrote:
dev_close() must be called holding the RTNL. Compile-tested only. Signed-off-by: Ben Hutchings <redacted> --- drivers/net/sky2.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)diff --git a/drivers/net/sky2.c b/drivers/net/sky2.c index f226bca..b9bdf88 100644 --- a/drivers/net/sky2.c +++ b/drivers/net/sky2.c@@ -4395,7 +4395,9 @@ static int sky2_resume(struct pci_dev *pdev) if (err) { printk(KERN_ERR PFX "%s: could not up: %d\n", dev->name, err); + rtnl_lock(); dev_close(dev); + rtnl_unlock(); goto out;
applied