Thread (34 messages) 34 messages, 7 authors, 2008-06-09

Re: 2.6.25 crash: EIP: [<c02e2f14>] xfrm_output_resume+0x64/0x100 ss:esp 0068:c03a1e5c

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2008-05-14 12:21:13
Also in: lkml
Subsystem: the rest · Maintainer: Linus Torvalds

Possibly related (same subject, not in this thread)

On Wed, May 14, 2008 at 02:03:05PM +0200, Marco Berizzi wrote:
game over :-((

I was going forward with git bisect but now kernel
doesn't compile anymore
  LD      drivers/misc/built-in.o
  CC      drivers/net/Space.o
  CC      drivers/net/loopback.o
In file included from include/net/sock.h:50,
                 from drivers/net/loopback.c:53:
include/linux/pcounter.h: In function 'pcounter_add':
include/linux/pcounter.h:87: error: 'struct pcounter' has no member
named 'value'
make[2]: *** [drivers/net/loopback.o] Error 1
make[1]: *** [drivers/net] Error 2
This patch should let you test that kernel:

commit e7d0362dd41e760f340c1b500646cc92522bd9d5
Author: Ilpo Järvinen [off-list ref]
Date:   Mon Nov 26 23:34:54 2007 +0800

    [PCOUNTER] Fix build error without CONFIG_SMP
    
    I keep getting this build error and couldn't find anyone fixing
    it in archives. ...Maybe all net developers except me build
    just SMP kernels :-).
    
    In file included from include/net/sock.h:50,
                     from ipc/mqueue.c:35:
    include/linux/pcounter.h: In function 'pcounter_add':
    include/linux/pcounter.h:87: error: 'struct pcounter' has no
    member named 'value'
    make[1]: *** [ipc/mqueue.o] Error 1
    make: *** [ipc] Error 2
    
    Signed-off-by: Ilpo Järvinen [off-list ref]
    Acked-by: Arnaldo Carvalho de Melo [off-list ref]
    Signed-off-by: Herbert Xu [off-list ref]
    Signed-off-by: David S. Miller [off-list ref]
diff --git a/include/linux/pcounter.h b/include/linux/pcounter.h
index 620aade..9c4760a 100644
--- a/include/linux/pcounter.h
+++ b/include/linux/pcounter.h
@@ -84,7 +84,7 @@ static inline int pcounter_getval(const struct pcounter *self)
 
 static inline void pcounter_add(struct pcounter *self, int inc)
 {
-	self->value += inc;
+	self->val += inc;
 }
 
 static inline int pcounter_getval(const struct pcounter *self)
Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help