[ofa-general] RE: [PATCH 11/13] QLogic VNIC: Driver utility file - implements various utility macros

Stephen,

Stephen Hemminger [mailto:shemminger@vyatta.com] wrote:

Ramachandra K [off-list ref] wrote:

quoted

+#define is_power_of2(value)	(((value) & ((value - 1))) == 0)
+#define ALIGN_DOWN(x, a)	((x)&(~((a)-1)))

In kernel.h already

Will fix this. Thanks.

quoted

+extern u32 vnic_debug;

Use msg level macros instead?

I am sorry, I did not understand this comment.

+
+#define SYS_INFO(fmt, arg...)					\
+	 PRINT_CONDITIONAL(KERN_INFO,				\
+			   "SYS",				\
+			   (vnic_debug & DEBUG_SYS_INFO),	\
+			   fmt, ##arg)
+
+#endif	/* VNIC_UTIL_H_INCLUDED */

Many of these are already in standard macros pr_info, pr_err etc.

These macros are for providing a debug log level functionality through
the vnic_debug module parameter.

Regards,
Ram