Stephen,

Stephen Hemminger [mailto:shemminger@vyatta.com] wrote:

quoted

On Wed, 30 Apr 2008 22:49:55 +0530
Ramachandra K [off-list ref] wrote:

<snip>

quoted

+static match_table_t vnic_opt_tokens = {
+	{VNIC_OPT_IOC_GUID, "ioc_guid=%s"},
+	{VNIC_OPT_DGID, "dgid=%s"},
+	{VNIC_OPT_PKEY, "pkey=%x"},
+	{VNIC_OPT_NAME, "name=%s"},
+	{VNIC_OPT_INSTANCE, "instance=%d"},
+	{VNIC_OPT_RXCSUM, "rx_csum=%s"},
+	{VNIC_OPT_TXCSUM, "tx_csum=%s"},
+	{VNIC_OPT_HEARTBEAT, "heartbeat=%d"},
+	{VNIC_OPT_IOC_STRING, "ioc_string=\"%s"},
+	{VNIC_OPT_IB_MULTICAST, "ib_multicast=%s"},
+	{VNIC_OPT_ERR, NULL}
+};

NO
1. Most of this shouldn't be done via sysfs (rx_csum, tx_csum, ...)
2. Sysfs is one value per file not name=value

The VNIC driver needs multiple parameters (IOCGUID, DGID etc) from user space
to connect to the EVIC. For this the "name=value" mechanism is used for
a write-only sysfs file as an input method to the driver.

The driver follows the one value per file sysfs rule when it returns any data
with each readable file returning only a single value.

Regards,
Ram