Thread (10 messages) 10 messages, 3 authors, 2008-03-29

Re: [PATCH 2/2] pasemi_mac: Netpoll support

From: Olof Johansson <hidden>
Date: 2008-03-26 15:08:28
Also in: linuxppc-dev

On Wed, Mar 26, 2008 at 03:41:01PM +0300, Valentine Barshak wrote:
quoted
+	pasemi_mac_tx_intr(mac->tx->chan.irq, mac->tx);
+	enable_irq(mac->tx->chan.irq);
+
+	disable_irq(mac->rx->chan.irq);
+	pasemi_mac_rx_intr(mac->rx->chan.irq, dev);
Shouldn't this actually be pasemi_mac_rx_intr(mac->rx->chan.irq, mac->rx)?
Yeah, it should. It used to take the netdev pointer instead. And the
void * argument means I never got a compiler warning from it.

Thanks!

-Olof
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help