Re: [PATCH 2/2] pasemi_mac: Netpoll support
From: Valentine Barshak <hidden>
Date: 2008-03-26 12:41:01
Also in:
linuxppc-dev
Olof Johansson wrote:
quoted hunk ↗ jump to hunk
Add netpoll support to allow use of netconsole. Signed-off-by: Nate Case <redacted> Signed-off-by: Olof Johansson <redacted>diff --git a/drivers/net/pasemi_mac.c b/drivers/net/pasemi_mac.c index abb1dc4..6030ffe 100644 --- a/drivers/net/pasemi_mac.c +++ b/drivers/net/pasemi_mac.c@@ -1648,6 +1648,26 @@ static int pasemi_mac_poll(struct napi_struct *napi, int budget) return pkts; } +#ifdef CONFIG_NET_POLL_CONTROLLER +/* + * Polling 'interrupt' - used by things like netconsole to send skbs + * without having to re-enable interrupts. It's not called while + * the interrupt routine is executing. + */ +static void pasemi_mac_netpoll(struct net_device *dev) +{ + const struct pasemi_mac *mac = netdev_priv(dev); + + disable_irq(mac->tx->chan.irq); + pasemi_mac_tx_intr(mac->tx->chan.irq, mac->tx); + enable_irq(mac->tx->chan.irq); + + disable_irq(mac->rx->chan.irq); + pasemi_mac_rx_intr(mac->rx->chan.irq, dev);
Shouldn't this actually be pasemi_mac_rx_intr(mac->rx->chan.irq, mac->rx)? Thanks, Valentine.
_______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev