Re: [PATCH 3/7] [NET]: uninline dev_alloc_skb, de-bloats a lot
From: Denys Vlasenko <hidden>
Date: 2008-03-28 22:36:22
Also in:
lkml
Attachments
- dev_alloc_skb_comment.diff [text/x-diff] 374 bytes · preview
From: Denys Vlasenko <hidden>
Date: 2008-03-28 22:36:22
Also in:
lkml
On Friday 28 March 2008 01:52, David Miller wrote:
From: Denys Vlasenko <redacted> Date: Fri, 28 Mar 2008 00:36:59 +0100quoted
Can you add a comment which explains the intent? +struct sk_buff *dev_alloc_skb(unsigned int length) +{ + /* There is more code here than it seems: + * __dev_alloc_skb is an inline */ + return __dev_alloc_skb(length, GFP_ATOMIC); +} +EXPORT_SYMBOL(dev_alloc_skb);I've applied his patch already, if you want this comment please submit the patch to add it and also please use the correct formatting of the comment.
Here it is. Signed-off-by: Denys Vlasenko <redacted> -- vda