Thread (29 messages) 29 messages, 7 authors, 2008-03-29

Re: [PATCH 1/7] [NET]: uninline skb_put, de-bloats a lot

From: David Miller <davem@davemloft.net>
Date: 2008-03-27 22:05:14
Also in: lkml

From: Joe Perches <joe@perches.com>
Date: Thu, 27 Mar 2008 12:10:50 -0700
On Thu, 2008-03-27 at 14:38 +0200, Ilpo Järvinen wrote:
quoted
Allyesconfig (v2.6.24-mm1):
I think this change is only good in severely memory
limited uses.  This will very likely negatively impact
high speed networking.  It's a speed/size trade off.
I severely doubt this, the bulk of the overhead of
skb_put() is the atomic operation, not whether the
instructions get executed inline or not.

Please run some tests before making claims like this.
I might give you some slack in this area if you've
been doing networking performance tuning for 10+ years
but you haven't.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help