Thread (5 messages) 5 messages, 2 authors, 2008-03-28

Re: [patch 02/21] drivers/net/3c501.c: replace init_module&cleanup_module with module_init&module_exit

From: Andrew Morton <akpm@linux-foundation.org>
Date: 2008-03-28 22:07:45

On Fri, 28 Mar 2008 21:47:55 +0000
Al Viro [off-list ref] wrote:
On Fri, Mar 28, 2008 at 02:41:16PM -0700, akpm@linux-foundation.org wrote:
quoted
Replace init_module and cleanup_module with static functions and
module_init/module_exit.
Would the esteemed sir bother to build the resulting tree with drivers
in question non-modular?

Damnit, people, try to think for a minute.  If these functions were
not called directly in non-modular case, the driver would not work
built-in.  Which is not apriori impossible, but might warrant some
further investigation.  Use of grep, for starters...
well...  The probe functions are still called, only they're now called at
initcall-time as well as from the infamous Space.c.

So I guess these patches should at least have removed the calls from
Space.c tables, but iirc things aren't as simple as that.  I don't remember
why.
IOW, please unapply the patches in question.
always happy to do that.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help