Re: [patch 02/21] drivers/net/3c501.c: replace init_module&cleanup_module with module_init&module_exit
From: Al Viro <viro@ZenIV.linux.org.uk>
Date: 2008-03-28 21:48:05
On Fri, Mar 28, 2008 at 02:41:16PM -0700, akpm@linux-foundation.org wrote:
Replace init_module and cleanup_module with static functions and module_init/module_exit.
Would the esteemed sir bother to build the resulting tree with drivers in question non-modular? Damnit, people, try to think for a minute. If these functions were not called directly in non-modular case, the driver would not work built-in. Which is not apriori impossible, but might warrant some further investigation. Use of grep, for starters... IOW, please unapply the patches in question.