Thread (50 messages) 50 messages, 11 authors, 2008-02-03

RE: [PATCH] Disable TSO for non standard qdiscs

From: Waskiewicz Jr, Peter P <hidden>
Date: 2008-02-02 01:55:31

I totally disagree with these POVs:

- 10G cards should be treated by default as 10G cards - not 
DSL modems,
  and common users shouldn't have to read any warnings or configs to
  see this.
- tc with TBF or HTB are professional tools; there should be 
added some
  warnings to manuals. But trying to change the way they work because
  we think we know better what users want, and changing BTW some other
  things (making debugging this later a hell), is simply disrespectful
  for target users of these tools. There are some wrappers or 
"creators"
  invented for this. And, BTW, I think I've seen somewhere a system
  which does this this other way - with creators for 
professionals. So,
  you could be right with this too...
Ok, maybe I'm not done quite yet.  Jarek is echo'ing my original point,
changing the behavior of the tool automatically (these qdiscs in
question) is not good for a normal end user.  It might be fine for
kernel developers, but not users of these tools, IMO.  A less disruptive
approach, such as a warning message printed when loading the qdisc if
TSO is enabled, and documenting recommended usage, I think is more
prudent here.

Cheers,
-PJ Waskiewicz
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help