Stephen Hemminger wrote:

On Thu, 31 Jan 2008 19:37:35 +0100
Andi Kleen [off-list ref] wrote:

quoted

On Thu, Jan 31, 2008 at 07:01:00PM +0100, Patrick McHardy wrote:

quoted

Andi Kleen wrote:

quoted

quoted

Fix the broken qdisc instead.

What do you mean? I don't think the qdiscs are broken.
I cannot think of any way how e.g. TBF can do anything useful
with large TSO packets.

Someone posted a patch some time ago to calculate the amount
of tokens needed in max_size portions and use that, but IMO
people should just configure TBF with the proper MTU for TSO.

TBF with 64k atomic units will always be chunky and uneven. I don't
think that's a useful goal. 

-Andi

Then change TBF to use skb_gso_segment?  Be careful, the fact that
one skb ends up queueing multiple skb's would cause issues to parent
qdisc (ie work generating qdisc).

How about keeping the TSO-capable flag on qdiscs, propagating
the non-capability up the tree and perform segmentation before
queueing to the root?