Thread (9 messages) 9 messages, 5 authors, 2008-01-30

Re: sis190 build breakage

From: Jeff Garzik <hidden>
Date: 2008-01-30 08:22:58

Sam Ravnborg wrote:
On Tue, Jan 29, 2008 at 11:03:10PM +0100, Francois Romieu wrote:
quoted
maximilian attems [off-list ref] :
quoted
  CC [M]  drivers/net/sis190.o
  drivers/net/sis190.c:329: error: sis190_pci_tbl causes a section type conflict
  make[5]: *** [drivers/net/sis190.o] Error 1

gcc --version
gcc (GCC) 4.1.2 20061115 (prerelease) (Debian 4.1.1-21)
Looks like a bug where __initdata has been used
for const data.
Searching:
static int __devinit sis190_get_mac_addr_from_apc(struct pci_dev *pdev,
                                                  struct net_device *dev)
{
        static const u16 __devinitdata ids[] = { 0x0965, 0x0966, 0x0968 };
        struct sis190_private *tp = netdev_priv(dev);
        struct pci_dev *isa_bridge;
        u8 reg, tmp8;

Try to change this is __initconst and it should be fixed.
We have __initconst now?

Three cheers, and a beer, to whomever did that...

	Jeff


Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help