Thread (9 messages) 9 messages, 5 authors, 2008-01-30

Re: sis190 build breakage

From: Francois Romieu <romieu@fr.zoreil.com>
Date: 2008-01-29 22:44:34
Subsystem: networking drivers, the rest · Maintainers: Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds

maximilian attems [off-list ref] :
[...]
probably i should to get interesting info.
Don't bother.

$ less +/devinitdata Documentation/pci.txt
[...]
Tips on when/where to use the above attributes:
        o The module_init()/module_exit() functions (and all
          initialization functions called _only_ from these)
          should be marked __init/__exit.

        o Do not mark the struct pci_driver.

        o The ID table array should be marked __devinitdata.

Could our documentation be wrong ?
diff --git a/drivers/net/sis190.c b/drivers/net/sis190.c
index b570402..2e9e88b 100644
--- a/drivers/net/sis190.c
+++ b/drivers/net/sis190.c
@@ -326,7 +326,7 @@ static const struct {
 	{ "SiS 191 PCI Gigabit Ethernet adapter" },
 };
 
-static struct pci_device_id sis190_pci_tbl[] __devinitdata = {
+static struct pci_device_id sis190_pci_tbl[] = {
 	{ PCI_DEVICE(PCI_VENDOR_ID_SI, 0x0190), 0, 0, 0 },
 	{ PCI_DEVICE(PCI_VENDOR_ID_SI, 0x0191), 0, 0, 1 },
 	{ 0, },
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help