Thread (7 messages) 7 messages, 2 authors, 2007-12-01

Re: [PATCH net-2.6.25 2/3][IPV4] Unify and cleanup calls to devinet_sysctl_register

From: Pavel Emelyanov <hidden>
Date: 2007-12-01 13:25:31

Herbert Xu wrote:
On Fri, Nov 30, 2007 at 09:26:58PM +0300, Pavel Emelyanov wrote:
quoted
Besides, the inet_device is passed to this function, but
it is not needed there at all - just the device name and
ifindex are required.
But it is called devinet_* so an in_dev kind of makes sense :)
quoted
 #ifdef CONFIG_SYSCTL
-	devinet_sysctl_register(in_dev, &in_dev->cnf);
+	devinet_sysctl_register(dev, &in_dev->cnf);
How about just giving it in_dev instead?
Hmm... Makes sense. Should I recreate the while set or
just make the incremental one?
Thanks,
Thanks,
Pavel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help