Re: [PATCH net-2.6.25 2/3][IPV4] Unify and cleanup calls to devinet_sysctl_register
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2007-12-01 13:20:02
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2007-12-01 13:20:02
On Fri, Nov 30, 2007 at 09:26:58PM +0300, Pavel Emelyanov wrote:
Besides, the inet_device is passed to this function, but it is not needed there at all - just the device name and ifindex are required.
But it is called devinet_* so an in_dev kind of makes sense :)
#ifdef CONFIG_SYSCTL - devinet_sysctl_register(in_dev, &in_dev->cnf); + devinet_sysctl_register(dev, &in_dev->cnf);
How about just giving it in_dev instead? Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} [off-list ref] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt