Thread (5 messages) 5 messages, 3 authors, 2007-12-12

Re: [PATCH 1/2] [net/wireless/iwlwifi] : iwlwifi 3945 Fix raceconditional panic.

From: Andrew Morton <hidden>
Date: 2007-12-12 11:43:48
Also in: linux-wireless, lkml

On Thu, 29 Nov 2007 10:42:49 +0900 "Joonwoo Park" [off-list ref] wrote:
quoted hunk ↗ jump to hunk
2007/11/29, Zhu Yi [off-list ref]:
quoted
Good catch. But it will be better if you add it into
iwl_cancel_deferred_work().
Thanks.
I agree with you. 
Actually, I considered it, but I was afraid of side effect.
Anyway, I'm attaching a new one.

Thanks.
Joonwoo

[net/wireless/iwlwifi] : iwlwifi 3945 Fix race conditional panic.

Signed-off-by: Joonwoo Park <redacted>
---
diff --git a/drivers/net/wireless/iwlwifi/iwl3945-base.c b/drivers/net/wireless/iwlwifi/iwl3945-base.c
index 465da4f..e51e872 100644
--- a/drivers/net/wireless/iwlwifi/iwl3945-base.c
+++ b/drivers/net/wireless/iwlwifi/iwl3945-base.c
@@ -8270,6 +8270,7 @@ static void iwl_cancel_deferred_work(struct iwl_priv *priv)
 {
 	iwl_hw_cancel_deferred_work(priv);
 
+	cancel_delayed_work_sync(&priv->init_alive_start);
 	cancel_delayed_work(&priv->scan_check);
 	cancel_delayed_work(&priv->alive_start);
 	cancel_delayed_work(&priv->post_associate);
Did drivers/net/wireless/iwlwifi/iwl4965-base.c get fixed in a simlar
fashion?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help