Re: [PATCH 1/2] [net/wireless/iwlwifi] : iwlwifi 3945 Fix race conditional panic.
From: Zhu Yi <hidden>
Date: 2007-11-29 01:13:00
Also in:
linux-wireless, lkml
On Wed, 2007-11-28 at 19:41 +0900, Joonwoo Park wrote:
quoted hunk ↗ jump to hunk
[net/wireless/iwlwifi] : iwlwifi 3945 Fix race conditional panic. Signed-off-by: Joonwoo Park <redacted> ---diff --git a/drivers/net/wireless/iwlwifi/iwl3945-base.cb/drivers/net/wireless/iwlwifi/iwl3945-base.c index 465da4f..ac6c4a9 100644--- a/drivers/net/wireless/iwlwifi/iwl3945-base.c +++ b/drivers/net/wireless/iwlwifi/iwl3945-base.c@@ -8570,6 +8570,7 @@ static void iwl_pci_remove(struct pci_dev *pdev) IWL_DEBUG_INFO("*** UNLOAD DRIVER ***\n"); mutex_lock(&priv->mutex); + cancel_delayed_work_sync(&priv->init_alive_start); set_bit(STATUS_EXIT_PENDING, &priv->status); __iwl_down(priv); mutex_unlock(&priv->mutex);
Good catch. But it will be better if you add it into iwl_cancel_deferred_work(). Thanks, -yi