Thread (28 messages) 28 messages, 7 authors, 2007-11-01

Re: [PATCH v4] FEC - fast ethernet controller for mpc52xx

From: <hidden>
Date: 2007-11-01 12:32:04
Also in: linuxppc-dev

+	while (bcom_buffer_done(priv->tx_dmatsk)) {
+		struct sk_buff *skb;
+		skb = bcom_retrieve_buffer(priv->tx_dmatsk, NULL, NULL);
+		/* Here (and in rx routines) would be a good place for
+		 * dma_unmap_single(), but bcom doesn't return bcom_bd of the
+		 * finished transfer, and _unmap is empty on this platfrom.
+		 */
+
Of course bestcomm let's you get back the bcom_bd ... What do you think
your second NULL parameter is for ?
Give it a pointer to a bcom_bd * and it will fill your pointer for you to
point to the bd you just got back.


   Sylvain
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help