On Fri, Oct 26, 2007 at 01:59:09PM +0200, Domen Puncer wrote:

+static irqreturn_t mpc52xx_fec_tx_interrupt(int irq, void *dev_id)
+{
+	struct net_device *dev = dev_id;
+	struct mpc52xx_fec_priv *priv = netdev_priv(dev);
+
+	spin_lock(&priv->lock);
+
+	while (bcom_buffer_done(priv->tx_dmatsk)) {
+		struct sk_buff *skb;
+		struct bcom_fec_bd *bd;
+		skb = bcom_retrieve_buffer(priv->tx_dmatsk, NULL,
+				(struct bcom_bd **)&bd);
+		/* Here (and in rx routines) would be a good place for
+		 * dma_unmap_single(), but bcom doesn't return bcom_bd of the
+		 * finished transfer, and _unmap is empty on this platfrom.
+		 */

Oops, you forgot to remove the above comment.  :)

Otherwise,
Acked-by: Dale Farnsworth <redacted>

Domen, thanks for all your work on this.  It's good to see it finally go in.

-Dale