Re: [PATCH 5/7] pci: Export the pci_restore_msi_state() function

On Mon, 2007-10-22 at 13:13 -0500, Linas Vepstas wrote:

On Mon, Oct 22, 2007 at 11:49:24AM +1000, Michael Ellerman wrote:

quoted

On pseries there's a chance it will work for PCI error recovery, but if
so it's just lucky that firmware has left everything configured the same
way. 

? The papr is quite clear that i is up to the OS to restore the msi
state after an eeh error.

Via direct config space access or via firmware change-msi calls ?

quoted

Yes I think so. That way we can properly reconfigure via the firmware
interface. The other option would be to design some new arch hook to do
resume, but just doing a disable/enable seems simpler to me.

Err, If you read the code for suspend/resume, it never actually calls
disable/enable (and thus doesn't go to the firmware); it calls 
restore_msi_state() function!

If suspend/resume needs to call firmware to restore the state, then,
at the moment, suspend/resume is broken.  As I mentioned earlier,
I presumed that no powerpc laptops currently use msi-enabled devices,
as otherwise, this would have been flushed out.

I don't know why you keep talking about powerpc laptops here ... 

Ben.