Thread (27 messages) flat view 27 messages, 6 authors, 2007-10-23

Re: [PATCH 5/7] pci: Export the pci_restore_msi_state() function

From: "Michael Chan" <mchan@broadcom.com>
Date: 2007-10-22 04:01:57

David Miller wrote:
I'm not so sure about this.

Perhaps, instead, you should do a pci_msi_disable() and
pci_msi_enable() in the error detection and recovery sequence.
If we just detected PCI errors on this slot, I don't think it's
a good idea to continue writing to the config space to disable
MSI.  Perhaps we can disable/enable after the slot reset.
Or, alternatively, save/restore those MSI registers by hand.
We can do that, but we'll have to do it ahead of time when we enable
MSI, not after errors have been detected.  But the address/data can
change as the CPU affinity changes during run time, right?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help