Re: [PATCH 2/2] Interface group match - netfilter part

On Oct 16 2007 10:30, Patrick McHardy wrote:

quoted

+static int match(const struct sk_buff *skb,

Potential symbol clash, name it ifgroup_match() for example.

quoted

+      const struct net_device *in,
+      const struct net_device *out,
+      const struct xt_match *match,
+      const void *matchinfo,
+      int offset,
+      unsigned int protoff,
+      int *hotdrop)

2.6.23 => bool ifgroup_match(... bool *hotdrop)

quoted

+static struct xt_match ifgroup_match = {
+	.name		= "ifgroup",
+	.match		= match,
+	.matchsize	= sizeof(struct xt_ifgroup_info),
+	.family		= AF_INET,
+	.me		= THIS_MODULE,
+};
+
+static struct xt_match ifgroup6_match = {
+	.name		= "ifgroup",
+	.match		= match,
+	.matchsize	= sizeof(struct xt_ifgroup_info),
+	.family		= AF_INET6,
+	.me		= THIS_MODULE,
+};

__read_mostly

And actually, an array,

	static struct xt_match ifgroup_match[] __read_mostly = {
		...
	}