Re: [PATCH 1/2] Interface group: core (netlink) part
From: Patrick McHardy <hidden>
Date: 2007-10-16 08:34:37
Also in:
netfilter-devel
Laszlo Attila Toth wrote:
quoted hunk ↗ jump to hunk
diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index 4756d58..18ff3c5 100644 --- a/net/core/rtnetlink.c +++ b/net/core/rtnetlink.c@@ -646,6 +646,9 @@ static int rtnl_fill_ifinfo(struct sk_buff *skb, struct net_device *dev, if (dev->master) NLA_PUT_U32(skb, IFLA_MASTER, dev->master->ifindex); + if (dev->ifgroup) + NLA_PUT_U32(skb, IFLA_IFGROUP, dev->ifgroup); +
You need to adjust if_nlmsg_size() to account for this.
quoted hunk ↗ jump to hunk
if (dev->qdisc_sleeping) NLA_PUT_STRING(skb, IFLA_QDISC, dev->qdisc_sleeping->ops->id);@@ -846,6 +849,11 @@ static int do_setlink(struct net_device *dev, struct ifinfomsg *ifm, write_unlock_bh(&dev_base_lock); } + if (tb[IFLA_IFGROUP]) { + dev->ifgroup = nla_get_u32(tb[IFLA_IFGROUP ]); + rtmsg_ifinfo(RTM_NEWLINK, dev, 0); + }
Notifcations should be atomic, not one for every single change. I know thats not the case currently, but it seems we're missing a notifcation for some of the attributes anyway (like tx_queue_len, operstate, linkmode), please consolidate all these and send a single notifcation.