Re: [2.6 patch] always export sysctl_{r,w}mem_max
From: Eric W. Biederman <hidden>
Date: 2007-10-26 23:21:13
Also in:
lkml
Adrian Bunk [off-list ref] writes:
This patch fixes the following build error with CONFIG_SYSCTL=n: <-- snip --> ... ERROR: "sysctl_rmem_max" [fs/dlm/dlm.ko] undefined! ERROR: "sysctl_wmem_max" [drivers/net/rrunner.ko] undefined! ERROR: "sysctl_rmem_max" [drivers/net/rrunner.ko] undefined! make[2]: *** [__modpost] Error 1
I was going to ask if allowing drivers to increase rmem_max is something that we want to do. Apparently the road runner driver has been doing this since the 2.6.12-rc1 when the git repository starts so this probably isn't a latent bug. So removing unnecessary #ifdef sounds good to me. Acked-by: "Eric W. Biederman" <redacted>
quoted hunk
<-- snip --> Signed-off-by: Adrian Bunk <bunk@kernel.org> --- 22ea6cd56e4fa844b0b1bbab2542f09eb6c9a5abdiff --git a/net/core/sock.c b/net/core/sock.c index febbcbc..ee1cc4f 100644 --- a/net/core/sock.c +++ b/net/core/sock.c@@ -2004,7 +2004,5 @@ EXPORT_SYMBOL(sock_wmalloc); EXPORT_SYMBOL(sock_i_uid); EXPORT_SYMBOL(sock_i_ino); EXPORT_SYMBOL(sysctl_optmem_max); -#ifdef CONFIG_SYSCTL EXPORT_SYMBOL(sysctl_rmem_max); EXPORT_SYMBOL(sysctl_wmem_max); -#endif