Thread (4 messages) 4 messages, 3 authors, 2007-09-13

Re: [PATCH][MIPS][7/7] AR7: ethernet

From: Ralf Baechle <hidden>
Date: 2007-09-13 11:36:05
Also in: linux-mips

Possibly related (same subject, not in this thread)

On Thu, Sep 13, 2007 at 02:42:46AM +0100, Thiemo Seufer wrote:
quoted
All struct members here are sized such that there is no padding needed, so
the packed attribute doesn't buy you anything - unless of course the
entire structure is missaligned but I don't see how that would be possible
in this driver so the __attribute__ ((packed)) should go - it result in
somwhat larger and slower code.
FWIW, a modern gcc will warn about such superfluous packed attributes,
that's another reason to remove those.
I doubt it will in this case; the packed structure is dereferenced by a
pointer so no way for gcc to know the alignment.

  Ralf
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help