Re: [PATCH][MIPS][7/7] AR7: ethernet
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2007-09-07 07:10:27
Also in:
linux-mips
Possibly related (same subject, not in this thread)
- 2007-09-29 · Re: [PATCH][MIPS][7/7] AR7: ethernet · Jeff Garzik <hidden>
- 2007-09-20 · [PATCH][MIPS][7/7] AR7: ethernet · Matteo Croce <hidden>
- 2007-09-13 · Re: [PATCH][MIPS][7/7] AR7: ethernet · Ralf Baechle <hidden>
- 2007-09-13 · Re: [PATCH][MIPS][7/7] AR7: ethernet · Thiemo Seufer <hidden>
- 2007-09-12 · Re: [PATCH][MIPS][7/7] AR7: ethernet · Ralf Baechle <hidden>
On Thu, 6 Sep 2007, Andrew Morton wrote:
quoted
On Thu, 6 Sep 2007 17:34:10 +0200 Matteo Croce [off-list ref] wrote: Driver for the cpmac 100M ethernet driver. It works fine disabling napi support, enabling it gives a kernel panic when the first IPv6 packet has to be forwarded. Other than that works fine.The driver does a lot of open-coded dma_cache_inv() calls (in a way which assumes a 32-bit bus, too). I assume that dma_cache_inv() is some mips
No, even i386 has it ;-)
thing. I'd have thought that it would be better to use the dma mapping API thoughout the driver, and its associated dma invalidation APIs.
However, Ralf just posted a patch to remove it on all architectures, and
driver writers should consider it gone.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds