Re: [PATCH] bonding: update some distro-specific documentation
From: Jay Vosburgh <hidden>
Date: 2007-09-12 18:47:40
Andy Gospodarek [off-list ref] wrote:
I could do that, or we could just take this as-is and get initscripts fixed up to account for this. Does that seem reasonable?
Changing initscripts is fine, too, but is there then going to be some (perhaps small) installed base for which the documentation will be incorrect?
quoted hunk ↗ jump to hunk
I'd rather go that route, and I've even got a patch that *seems* to work already:--- initscripts-8.45.17.EL/sysconfig/network-scripts/ifup-eth.orig +++ initscripts-8.45.17.EL/sysconfig/network-scripts/ifup-eth@@ -125,7 +125,16 @@ if [ "$ISALIAS" = no ] && is_bonding_dev for arg in $BONDING_OPTS ; do key=${arg%%=*}; value=${arg##*=}; - echo $value > /sys/class/net/${DEVICE}/bonding/$key + OLDIFS=$IFS; + IFS=','; + if [ "${key}" = "arp_ip_target" ]; then + for arp_ip in $value; do + echo +$arp_ip > /sys/class/net/${DEVICE}/bonding/$key + done + else + echo $value > /sys/class/net/${DEVICE}/bonding/$key + fi + IFS=$OLDIFS; done /sbin/ip link set dev ${DEVICE} up
That looks like it should do the right thing, although I didn't actually try it. The other bonding sysfs thingies that use the "+" type of syntax don't appear in BONDING_OPTS. -J --- -Jay Vosburgh, IBM Linux Technology Center, fubar@us.ibm.com