Re: [PATCH 1/1] ipv6: corrects sended rtnetlink message
flat view
From: Thomas Graf <tgraf@suug.ch>
Date: 2007-09-07 10:11:17
* Milan Kocian [off-list ref] 2007-09-06 23:05
I agree but ipv6 sends on device change (NETDEV_DOWN) RTM_DELLINK message. BTW when ipv6 send LINK message on NETDEV_UNREGISTER event, why doesn't send message on NETDEV_REGISTER event? No symmetry ?
You should be seeing two RTM_DELLINK upon NETDEV_UNREGISTER if the
interface carried any IPv6 addresess. Once with ifi_change=~0
notifying you that the device is disappearing and once with
ifi_change=0 coming from the IPv6 protocol shutdown.
ok. However, if I understand, LINK messages handle device changes not protocol changes. Or not ?
Yes, I personally think this behaviour is wrong but we can't remove it
unless we are sure it doesn't break anything.
Now I ignore (RTM_DELLINK && ifi_family==AF_INET6) :-). But it's only workaround till next change.
That's also correct, pure netdevice notification will always be sent
with the ifi_family set to AF_UNSPEC.
Hard to find it. I can try to look at other routing sw (probably most using it) about handling with RTM_DELLINK. Howerer when was made change from RTM_NEWLINK to RTM_DELLINK without protests, we can try remove message :-)
I'd give the USAGI software tree a short peek, if there was a specific
reason for adding this notification in the first place, the software is
most probably found in that tree.