[PATCH 1/1] ipv6: corrects sended rtnetlink message
flat view
STALE6987d
From: Milan Kocian <hidden>
Date: 2007-08-15 14:55:07
Subsystem:
networking [general], networking [ipv4/ipv6], the rest · Maintainers:
"David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, David Ahern, Ido Schimmel, Linus Torvalds
ipv6 sends a RTM_DELLINK netlink message on both events: NETDEV_DOWN,
NETDEV_UNREGISTER. Corrected by sending RTM_NEWLINK on NETDEV_DOWN event
and RTM_DELLINK on NETDEV_UNREGISTER event.
---
btw. I don't know why protocol sends a NL messages about iface state
changes. It comes from other sources. By contrast ipv6 doesn't send
no message on NETDEV_UP event !? IMO best possibility is deletion of
sending this message.
--- a/net/ipv6/addrconf.c 2007-08-13 11:35:23.481430029 +0200
+++ b/net/ipv6/addrconf.c 2007-08-13 12:47:01.825690662 +0200@@ -2488,7 +2488,10 @@ static int addrconf_ifdown(struct net_de /* Step 5: netlink notification of this interface */ idev->tstamp = jiffies; - inet6_ifinfo_notify(RTM_DELLINK, idev); + if (how) + inet6_ifinfo_notify(RTM_DELLINK, idev); + else + inet6_ifinfo_notify(RTM_NEWLINK, idev); /* Shot the device (if unregistered) */
Signed-off-by: Milan Kocian <redacted>