Re: [patch 02/18] sundance: PHY address form 0, only for device I D 0x0200 (IP100A) (20070605)
From: Jeff Garzik <hidden>
Date: 2007-09-03 10:42:58
黃建興-Jesse wrote:
quoted hunk
+++ a/drivers/net/sundance.c@@ -559,7 +559,11 @@ static int __devinit sundance_probe1 (st * It seems some phys doesn't deal well with address 0 beingaccessed * first, so leave address zero to the end of the loop (32 & 31). */ - for (phy = 1; phy <= 32 && phy_idx < MII_CNT; phy++) { + if (sundance_pci_tbl[np->chip_id].device == 0x0200) + phy = 0; + else + phy = 1; + for (; phy <= 32 && phy_idx < MII_CNT; phy++) {
As I noted in the last email, this patch still has a bug: In the above loop code being modified, you need to change two things: 1) Initial loop value 2) Loop terminating condition Your patch only performs change #1. Jeff