Re: [PATCH] drivers/net/ibmveth.c: memset fix
From: Brian King <hidden>
Date: 2007-08-07 15:41:06
Also in:
lkml
Mariusz Kozlowski wrote:
quoted
quoted
quoted
Looks like memset() is zeroing wrong nr of bytes.Good catch, however, I think we can just remove this memset altogether since the memory gets allocated via kzalloc.Correct, that memset() is superfluous.Ok. Then this should do it.
Acked-by: Brian King <redacted>
quoted hunk ↗ jump to hunk
Signed-off-by: Mariusz Kozlowski <redacted> drivers/net/ibmveth.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)--- linux-2.6.23-rc1-mm2-a/drivers/net/ibmveth.c 2007-08-01 08:43:46.000000000 +0200 +++ linux-2.6.23-rc1-mm2-b/drivers/net/ibmveth.c 2007-08-06 23:32:13.000000000 +0200@@ -963,7 +963,7 @@ static int __devinit ibmveth_probe(struc { int rc, i; struct net_device *netdev; - struct ibmveth_adapter *adapter = NULL; + struct ibmveth_adapter *adapter; unsigned char *mac_addr_p; unsigned int *mcastFilterSize_p;@@ -997,7 +997,6 @@ static int __devinit ibmveth_probe(struc SET_MODULE_OWNER(netdev); adapter = netdev->priv; - memset(adapter, 0, sizeof(adapter)); dev->dev.driver_data = netdev; adapter->vdev = dev; -To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
-- Brian King Linux on Power Virtualization IBM Linux Technology Center