[PATCH] drivers/net/ibmveth.c: memset fix

STALE6951d

6 messages, 4 authors, 2007-08-07 · open the first message on its own page

[PATCH] drivers/net/ibmveth.c: memset fix

From: Mariusz Kozlowski <hidden>
Date: 2007-08-06 20:17:21 

Hello,

	Looks like memset() is zeroing wrong nr of bytes.

Signed-off-by: Mariusz Kozlowski <redacted>

 drivers/net/ibmveth.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- linux-2.6.23-rc1-mm2-a/drivers/net/ibmveth.c	2007-08-01 08:43:46.000000000 +0200
+++ linux-2.6.23-rc1-mm2-b/drivers/net/ibmveth.c	2007-08-06 20:34:44.000000000 +0200
@@ -963,7 +963,7 @@ static int __devinit ibmveth_probe(struc
 {
 	int rc, i;
 	struct net_device *netdev;
-	struct ibmveth_adapter *adapter = NULL;
+	struct ibmveth_adapter *adapter;

 	unsigned char *mac_addr_p;
 	unsigned int *mcastFilterSize_p;
@@ -997,7 +997,7 @@ static int __devinit ibmveth_probe(struc
 	SET_MODULE_OWNER(netdev);

 	adapter = netdev->priv;
-	memset(adapter, 0, sizeof(adapter));
+	memset(adapter, 0, sizeof(*adapter));
 	dev->dev.driver_data = netdev;

 	adapter->vdev = dev;

Re: [PATCH] drivers/net/ibmveth.c: memset fix

From: Brian King <hidden>
Date: 2007-08-06 20:37:26 

Mariusz Kozlowski wrote:
Hello,

	Looks like memset() is zeroing wrong nr of bytes.
Good catch, however, I think we can just remove this memset altogether
since the memory gets allocated via kzalloc.

-Brian
quoted hunk
Signed-off-by: Mariusz Kozlowski <redacted>

 drivers/net/ibmveth.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- linux-2.6.23-rc1-mm2-a/drivers/net/ibmveth.c	2007-08-01 08:43:46.000000000 +0200
+++ linux-2.6.23-rc1-mm2-b/drivers/net/ibmveth.c	2007-08-06 20:34:44.000000000 +0200
@@ -963,7 +963,7 @@ static int __devinit ibmveth_probe(struc
 {
 	int rc, i;
 	struct net_device *netdev;
-	struct ibmveth_adapter *adapter = NULL;
+	struct ibmveth_adapter *adapter;

 	unsigned char *mac_addr_p;
 	unsigned int *mcastFilterSize_p;
@@ -997,7 +997,7 @@ static int __devinit ibmveth_probe(struc
 	SET_MODULE_OWNER(netdev);

 	adapter = netdev->priv;
-	memset(adapter, 0, sizeof(adapter));
+	memset(adapter, 0, sizeof(*adapter));
 	dev->dev.driver_data = netdev;

 	adapter->vdev = dev;
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Brian King
Linux on Power Virtualization
IBM Linux Technology Center

Re: [PATCH] drivers/net/ibmveth.c: memset fix

From: Jeff Garzik <hidden>
Date: 2007-08-06 20:44:24 

Brian King wrote:
Mariusz Kozlowski wrote:
quoted
Hello,

	Looks like memset() is zeroing wrong nr of bytes.
Good catch, however, I think we can just remove this memset altogether
since the memory gets allocated via kzalloc.
Correct, that memset() is superfluous.

	Jeff

Re: [PATCH] drivers/net/ibmveth.c: memset fix

From: Mariusz Kozlowski <hidden>
Date: 2007-08-06 21:44:23

quoted
quoted
	Looks like memset() is zeroing wrong nr of bytes.
Good catch, however, I think we can just remove this memset altogether
since the memory gets allocated via kzalloc.
Correct, that memset() is superfluous.
Ok. Then this should do it.

Signed-off-by: Mariusz Kozlowski <redacted>

 drivers/net/ibmveth.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- linux-2.6.23-rc1-mm2-a/drivers/net/ibmveth.c	2007-08-01 08:43:46.000000000 +0200
+++ linux-2.6.23-rc1-mm2-b/drivers/net/ibmveth.c	2007-08-06 23:32:13.000000000 +0200
@@ -963,7 +963,7 @@ static int __devinit ibmveth_probe(struc
 {
 	int rc, i;
 	struct net_device *netdev;
-	struct ibmveth_adapter *adapter = NULL;
+	struct ibmveth_adapter *adapter;

 	unsigned char *mac_addr_p;
 	unsigned int *mcastFilterSize_p;
@@ -997,7 +997,6 @@ static int __devinit ibmveth_probe(struc
 	SET_MODULE_OWNER(netdev);

 	adapter = netdev->priv;
-	memset(adapter, 0, sizeof(adapter));
 	dev->dev.driver_data = netdev;

 	adapter->vdev = dev;

Re: [PATCH] drivers/net/ibmveth.c: memset fix

From: Brian King <hidden>
Date: 2007-08-07 15:41:06 

Mariusz Kozlowski wrote:
quoted
quoted
quoted
	Looks like memset() is zeroing wrong nr of bytes.
Good catch, however, I think we can just remove this memset altogether
since the memory gets allocated via kzalloc.
Correct, that memset() is superfluous.
Ok. Then this should do it.
Acked-by: Brian King <redacted>
quoted hunk
Signed-off-by: Mariusz Kozlowski <redacted>

 drivers/net/ibmveth.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- linux-2.6.23-rc1-mm2-a/drivers/net/ibmveth.c	2007-08-01 08:43:46.000000000 +0200
+++ linux-2.6.23-rc1-mm2-b/drivers/net/ibmveth.c	2007-08-06 23:32:13.000000000 +0200
@@ -963,7 +963,7 @@ static int __devinit ibmveth_probe(struc
 {
 	int rc, i;
 	struct net_device *netdev;
-	struct ibmveth_adapter *adapter = NULL;
+	struct ibmveth_adapter *adapter;

 	unsigned char *mac_addr_p;
 	unsigned int *mcastFilterSize_p;
@@ -997,7 +997,6 @@ static int __devinit ibmveth_probe(struc
 	SET_MODULE_OWNER(netdev);

 	adapter = netdev->priv;
-	memset(adapter, 0, sizeof(adapter));
 	dev->dev.driver_data = netdev;

 	adapter->vdev = dev;
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Brian King
Linux on Power Virtualization
IBM Linux Technology Center

Re: [PATCH] drivers/net/ibmveth.c: memset fix

From: Jeff Garzik <hidden>
Date: 2007-08-07 22:00:37 

Mariusz Kozlowski wrote:
quoted
quoted
quoted
	Looks like memset() is zeroing wrong nr of bytes.
Good catch, however, I think we can just remove this memset altogether
since the memory gets allocated via kzalloc.
Correct, that memset() is superfluous.
Ok. Then this should do it.

Signed-off-by: Mariusz Kozlowski <redacted>

 drivers/net/ibmveth.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
applied
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help