Re: [PATCH 0/9 Rev3] Implement batching skb API and support in IPoIB
From: Krishna Kumar2 <hidden>
Date: 2007-08-23 02:42:27
From: Krishna Kumar2 <hidden>
Date: 2007-08-23 02:42:27
David Miller [off-list ref] wrote on 08/22/2007 02:44:40 PM:
From: Krishna Kumar2 <redacted> Date: Wed, 22 Aug 2007 12:33:04 +0530quoted
Does turning off batching solve that problem? What I mean by that is: batching can be disabled if a TSO device is worse for some cases.This new batching stuff isn't going to be enabled or disabled on a per-device basis just to get "parity" with how things are now. It should be enabled by default, and give at least as good performance as what can be obtained right now.
That was how it was in earlier revisions. In revision4 I coded it so that it is enabled only if explicitly set by the user. I can revert that change.
Otherwise it's a clear regression.
Definitely. For drivers that support it, it should not reduce performance. Thanks, - KK