[ofa-general] Re: [PATCH 0/9 Rev3] Implement batching skb API and support in IPoIB
From: Krishna Kumar2 <hidden>
Date: 2007-08-22 04:11:52
From: Krishna Kumar2 <hidden>
Date: 2007-08-22 04:11:52
David Miller [off-list ref] wrote on 08/22/2007 12:21:43 AM:
From: jamal <redacted> Date: Tue, 21 Aug 2007 08:30:22 -0400quoted
On Tue, 2007-21-08 at 00:18 -0700, David Miller wrote:quoted
Using 16K buffer size really isn't going to keep the pipe full enough for TSO.Why the comparison with TSO (or GSO for that matter)?Because TSO does batching already, so it's a very good "tit for tat" comparison of the new batching scheme vs. an existing one.
I am planning to do more testing on your suggestion over the weekend, but I had a comment. Are you saying that TSO and batching should be mutually exclusive so hardware that doesn't support TSO (like IB) only would benefit? But even if they can co-exist, aren't cases like sending multiple small skbs better handled with batching? Thanks, - KK