Re: [PATCH 2/4] ibmveth: Implement ethtool hooks to enable/disable checksum offload

ext Brian King wrote:

Ragner Magalhaes wrote:

quoted

ext Brian King wrote:

quoted

+
+static int ibmveth_set_rx_csum(struct net_device *dev, u32 data)
+{
+	struct ibmveth_adapter *adapter = dev->priv;
+

Why do not to do

	if ((data && adapter->rx_csum) || (!data && !adapter->rx_csum))
		return 0;
less two lines.

Ok.

quoted

here also, as above ...

quoted

+	if (data && (dev->features & NETIF_F_IP_CSUM))
+		return 0;
+	if (!data && !(dev->features & NETIF_F_IP_CSUM))
+		return 0;

This change would make the line > 80 columns, which I prefer to avoid.
Updated patch attached which addresses the first comment.

I think would not be ugly to make.

	if ((data && (dev->features & NETIF_F_IP_CSUM)) ||
		(!data && !(dev->features & NETIF_F_IP_CSUM)))
		return 0;

Thanks,

Brian

---

Thanks,

Ragner