Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select"
From: Randy Dunlap <hidden>
Date: 2007-05-07 20:49:00
Also in:
lkml
On Mon, 07 May 2007 16:31:48 -0400 Jeff Garzik wrote:
Satyam Sharma wrote:quoted
Yes, mixing select and depends is a recipe for build disasters. Call me a rabid fanatic, but I would in fact go as far as to say that this whole "select" thing in the Kconfig process is one big BUG, and not a feature. People are lazy by nature and would rather just "select" a dependency for their config option than burden users with several "depends".Tough, the kernel community has voted against you.
Andrew (usually) implores people not to use "select" and I agree with him.
It makes far more sense to include a driver during kernel configuration, and have that driver pull in its libraries via 'select'. The lame alternative requires developers to know which libraries they need BEFORE picking their drivers, which is backwards and requires legwork on the part of the kernel developer.
Developers? If you had said "users," I might agree, but IMO it's OK (or even Good) for developers to know what libraries their code uses/requires. Yes, that's a good thing. --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***