Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select"

Hi,

On Mon, 7 May 2007, Krzysztof Halasa wrote:

Roman Zippel [off-list ref] writes:

quoted

HDLC doesn't really look like simple library code, what's up with all the 
HDLC_* options?

Sub-modules.

So it's not simple library code, or is it?

Anyway, what does the patch "screw" exactly?

Normal dependencies, you basically have to manually make sure they are 
correct (and it seems with your patch they aren't). Again, _please_ (with 
sugar on top) don't use select unless you have a good reason for it.

bye, Roman