Re: [PATCH 2/2] [SK_BUFF]: Introduce skb_copy_from_linear_data{_offset}
From: Arnaldo Carvalho de Melo <hidden>
Date: 2007-03-27 23:07:52
On 3/27/07, David Miller [off-list ref] wrote:
From: "Arnaldo Carvalho de Melo" <redacted> Date: Tue, 27 Mar 2007 18:56:11 -0300quoted
On 3/27/07, David Miller [off-list ref] wrote:quoted
From: Arnaldo Carvalho de Melo <redacted> Date: Tue, 27 Mar 2007 16:41:48 -0300quoted
+static inline void skb_move_linear_data(const struct sk_buff *skb, + const int from_offset, + const int to_offset, + const unsigned int len) +{ + memcpy(skb->data + to_offset, skb->data + from_offset, len); +} +What do you intend to use this for? There are no users in your patch, and I'd be fearful of overlapping cases (which ought to be common for anything using this) which therefore would require use of memmove() instead of memcpy(). How about we just leave out interfaces until we have a use case?It should be ok now, please take a look in a throwaway branch to make sure, sorry for the disturbance.
Okay, Hairaru is this way: master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.22 :-) - Arnaldo