Re: [PATCH 2/2] [SK_BUFF]: Introduce skb_copy_from_linear_data{_offset}
From: Patrick McHardy <hidden>
Date: 2007-03-27 21:36:20
From: Patrick McHardy <hidden>
Date: 2007-03-27 21:36:20
Arnaldo Carvalho de Melo wrote:
On 3/27/07, Patrick McHardy [off-list ref] wrote:quoted
nf_nat_helper.c:mangle_content() could make use of this, but it would need memmove. Something to do this with non-linear packets would be even cooler :)Damn, that was so fast man! For the qeth case that motivated me to try the leftover it was like: memcpy is the fastest way, memmove would be more costly but more general, when in doubt I just droppped the users without removing the infrastructure, nah, lets leave this for another day, for now I'll just drop the non-used -new infrastrucure and resubmit.
Yes, as long as it doesn't help with anything else it doesn't seem too useful. It did motivate me to try the non-linear skb mangling though :)