On Fri, Jan 26, 2007 at 09:45:18PM +1100, Herbert Xu wrote:

On Fri, Jan 26, 2007 at 11:18:38AM +0100, Jarek Poplawski wrote:

quoted

I don't mean it's necessary. I mean now skb is freed
unconditionally and after this patch, if there is some
error in counting, skb will stay. I thought Masayuki
wrote about such possibility, but if I missed his
point, then the rest is really O.K.

OK, I see what you mean.

I'm not aware of anybody who has coded in this way.  Alexey & Dave,
do you know of any place where __kfree_skb is used to free an skb
whose ref count is greater than 1?

I'm sure it wasn't done on purpose! But it could hide
some errors anyway.

Jarek P.