Re: [PATCH] TCP: Replace __kfree_skb() with kfree_skb()
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2007-01-26 10:45:45
On Fri, Jan 26, 2007 at 11:18:38AM +0100, Jarek Poplawski wrote:
I don't mean it's necessary. I mean now skb is freed unconditionally and after this patch, if there is some error in counting, skb will stay. I thought Masayuki wrote about such possibility, but if I missed his point, then the rest is really O.K.
OK, I see what you mean. I'm not aware of anybody who has coded in this way. Alexey & Dave, do you know of any place where __kfree_skb is used to free an skb whose ref count is greater than 1? Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} [off-list ref] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt