On Tue, 2006-12-12 at 06:49 +0100, Eric Lemoine wrote:

On 12/12/06, Benjamin Herrenschmidt [off-list ref] wrote:

quoted

On Tue, 2006-12-12 at 06:33 +0100, Eric Lemoine wrote:

quoted

On 12/12/06, David Miller [off-list ref] wrote:

quoted

[...]
Anyways, Eric your changes look fine as far as I can tell, can you
give them a really good testing on some SMP boxes?

Unfortunately I can't, I don't have the hardware (only an old ibook here).

I do however, I'll give it a beating on a dual G5 as soon as I get a
chance. I'm pretty swamped at the moment and the box is used by somebody
else today.

Ok, thanks a lot Benjamin.

Patched driver's been running fine for a couple of days & nights with
constant beating... just those RX MAC fifo overflows every now and then
(though they cause no data corruption and no big hit on the driver perfs
neither). I suppose still worth investigating when I have a bit of time,
I must have done something stupid with the pause settings.

In the meantime, Eric's patch is all good.

Ben.