Thread (1 message) 1 message, 1 author, 2006-12-01

Re: [NET_SCHED]: policer: restore compatibility with old iproute binaries

From: David Miller <davem@davemloft.net>
Date: 2006-12-01 03:54:26

From: jamal <redacted>
Date: Thu, 30 Nov 2006 06:43:36 -0500
On 11/26/06, Patrick McHardy [off-list ref] wrote:
quoted


[NET_SCHED]: policer: restore compatibility with old iproute binaries

The tc actions increased the size of struct tc_police, which broke
compatibility with old iproute binaries since both the act_police
and the old NET_CLS_POLICE code check for an exact size match.

Since the new members are not even used, the simple fix is to also
accept the size of the old structure. Dumping is not affected since
old userspace will receive a bigger structure, which is handled fine.

Signed-off-by: Patrick McHardy <redacted>

Sorry, couldnt respond sooner. Was travelling and overloaded.
Looks good although i havent run any of my tests. I will at some point.

Acked-by: Jamal Hadi  Salim
Applied to net-2.6.20, and I'll push this to -stable too.

Thanks everyone.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help