Thread (26 messages) 26 messages, 6 authors, 2006-11-04

Re: [PATCH 2/2] usbnet: use MII hooks only if CONFIG_MII is enabled

From: Greg KH <hidden>
Date: 2006-11-02 07:22:39
Also in: lkml

On Wed, Oct 25, 2006 at 07:22:08PM -0700, David Brownell wrote:
On Wednesday 25 October 2006 4:58 pm, Randy Dunlap wrote:
quoted
On Wed, 25 Oct 2006 15:27:09 -0700 David Brownell wrote:
quoted
Instead, "usbnet.c" should #ifdef the relevant ethtool hooks
according to CONFIG_MII ... since it's completely legit to
use usbnet with peripherals that don't need MII.
I had in mind something simpler -- #ifdeffing the entire functions,
as in this patch.  It looks more complicated than it is, because
"diff" gets confused by moving two functions earlier in the file.

(Thanks for starting this, Randy ... these two patches should be merged
before RC4 ships.)
Argh, there were just too many different versions of these patches
floating around.  Can you resend the final versions please?

thanks,

greg k-h
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help