Thread (26 messages) 26 messages, 6 authors, 2006-11-04

Re: [linux-usb-devel] [PATCH 2/2] usbnet: use MII hooks only if CONFIG_MII is enabled

From: Adrian Bunk <hidden>
Date: 2006-11-01 01:23:49
Also in: lkml

On Tue, Oct 31, 2006 at 11:36:52AM -0800, David Brownell wrote:
quoted
quoted
		...
		depends on MII if MII != n

except that Kconfig doesn't comprehend conditionals like that.
You can express this in Kconfig:
	depends MII || MII=n
Except that:

Warning! Found recursive dependency: USB_USBNET USB_NET_AX8817X MII USB_USBNET

I think this is another case where Kconfig gets in the way and forces
introduction of a pseudovariable.  I'll give that a try.
quoted
But my suggestion was:
#if defined(CONFIG_MII) || (defined(CONFIG_MII_MODULE) && defined(MODULE))

Or simply select MII ...
Nope; those both prevent completely legit configurations.
MII is not required, except for those two adapter options.
What should work (with the USB_NET_MCS7830 part from Randy's patch 
removed) together with your patch and the
  #if defined(CONFIG_MII) || (defined(CONFIG_MII_MODULE) && defined(MODULE))
is:

config USB_USBNET
        tristate "Multi-purpose USB Networking Framework"
        select MII if USB_NET_AX8817X!=n || USB_NET_MCS7830!=n
	---help---
	  ...

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help