Thread (15 messages) 15 messages, 5 authors, 2007-01-02
  • (off-list ancestor, not in this archive)
  • pktgen (was Re: tests of kernel modules) · Alexey Dobriyan <hidden> · 2006-11-21
  • Re: pktgen · David Miller <davem@davemloft.net> · 2006-11-28
  • Re: pktgen · Alexey Dobriyan <hidden> · 2006-11-29
  • Re: pktgen · David Miller <davem@davemloft.net> · 2006-11-30
  • Re: pktgen · Alexey Dobriyan <hidden> · 2006-11-30
  • Re: pktgen · Robert Olsson <hidden> · 2006-11-30
  • Re: pktgen · Ben Greear <hidden> · 2006-11-30
  • Re: pktgen · David Miller <davem@davemloft.net> · 2006-12-01
  • Re: pktgen · Robert Olsson <hidden> · 2006-12-01
  • Re: pktgen · Alexey Dobriyan <hidden> · 2006-12-01
  • Re: pktgen · Robert Olsson <hidden> · 2006-12-01
  • Re: pktgen · David Miller <davem@davemloft.net> · 2006-12-01
  • Re: pktgen · David Miller <davem@davemloft.net> · 2007-01-02
  • Re: pktgen · Christoph Hellwig <hch@infradead.org> · 2006-12-01
  • Re: pktgen · David Miller <davem@davemloft.net> · 2006-12-01

Re: pktgen

From: Ben Greear <hidden>
Date: 2006-11-30 17:32:21

Possibly related (same subject, not in this thread)

Robert Olsson wrote:
quoted hunk ↗ jump to hunk
Hello!

Seems you found a race when rmmod is done before it's fully started

Try:
diff --git a/net/core/pktgen.c b/net/core/pktgen.c
index 733d86d..ac0b4b1 100644
--- a/net/core/pktgen.c
+++ b/net/core/pktgen.c
@@ -160,7 +160,7 @@
 #include <asm/div64.h>		/* do_div */
 #include <asm/timex.h>
 
-#define VERSION  "pktgen v2.68: Packet Generator for packet performance testing.\n"
+#define VERSION  "pktgen v2.69: Packet Generator for packet performance testing.\n"
 
 /* #define PG_DEBUG(a) a */
 #define PG_DEBUG(a)
@@ -3673,6 +3673,8 @@ static void __exit pg_cleanup(void)
 	struct list_head *q, *n;
 	wait_queue_head_t queue;
 	init_waitqueue_head(&queue);
+	
+	schedule_timeout_interruptible(msecs_to_jiffies(125));
 
 	/* Stop all interfaces & threads */
 
  
That strikes me as a hack..surely there is a better method than just adding
a sleep??

Ben

-- 
Ben Greear [off-list ref] 
Candela Technologies Inc  http://www.candelatech.com

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help